Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to generated PDF #271

Open
bast opened this issue Aug 23, 2023 · 5 comments
Open

Link to generated PDF #271

bast opened this issue Aug 23, 2023 · 5 comments

Comments

@bast
Copy link
Member

bast commented Aug 23, 2023

We plan to generate PDF as part of the Sphinx workflow. Let's not forget to link to the PDF from somewhere so that we find it.

It is currently called like this: https://coderefinery.github.io/documentation/_static/lesson.pdf

This does not exist yet at time of issue creation.

@rkdarst
Copy link
Member

rkdarst commented Sep 6, 2023

should the PDF name include the lesson name, so that when it's downloaded it has a good name automatically?
(makes automation across all lessons a bit harder. is it worth it? is filename for download something people will even use?)

@bast
Copy link
Member Author

bast commented Sep 6, 2023

I would keep a generic name so that we can copy paste the workflow. The inconvenience for the client is minimal IMO.

@bast
Copy link
Member Author

bast commented Sep 23, 2023

@rkdarst
Copy link
Member

rkdarst commented Sep 23, 2023

lesson.pdf, lesson (1).pdf, lesson (2).pdf, etc for all lessons would be at least a little bit annoying to me. My browser (and most by default? at least I didn't set it this way) automatically saves with the remote filenames.

To change name: it can be configured in conf.py with pyppeteer_basename. Changing links in all the lessons is a bit annoying, though... maybe not worth it yet? pdf=$(ls *.pdf) is at least minorly scirptable?

@bast
Copy link
Member Author

bast commented Sep 23, 2023

"Changing links in all the lessons is a bit annoying, though" - which links are these?

We could provide a bash script that wgets and renames all. But I also don't mind if each has a unique pdf name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants