Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid handling ping after close frame has been sent #394

Closed
wants to merge 2 commits into from
Closed

Avoid handling ping after close frame has been sent #394

wants to merge 2 commits into from

Conversation

bhallionOhbibi
Copy link

Fixes #298

@bhallionOhbibi bhallionOhbibi requested a review from nhooyr as a code owner May 25, 2023 10:36
@bhallionOhbibi bhallionOhbibi mentioned this pull request May 25, 2023
Closed
@bhallionOhbibi
Copy link
Author

Any chance you have time to take a quick look at this ?
This fix is quite simple :D

@nhooyr
Copy link
Contributor

nhooyr commented Sep 28, 2023

Will do soon #402

Need to get #256 done first.

@nhooyr nhooyr changed the base branch from master to dev October 13, 2023 07:29
@nhooyr nhooyr force-pushed the dev branch 2 times, most recently from 825873c to 9b5a15b Compare October 13, 2023 07:33
@nhooyr nhooyr added this to the v1.8.8 milestone Oct 13, 2023
@nhooyr nhooyr force-pushed the dev branch 5 times, most recently from 3500fce to a94999f Compare October 14, 2023 13:10
@nhooyr
Copy link
Contributor

nhooyr commented Oct 19, 2023

Unfortunately this doesn't work. writeFrame already has a check like this built in so it makes sense it doesn't work. There is definitely a bug in #298, but need to dig deeper to figure out what.

See the test I added to your commit, it still fails.

@nhooyr nhooyr force-pushed the dev branch 2 times, most recently from 268b079 to e4879ab Compare October 19, 2023 05:16
@nhooyr
Copy link
Contributor

nhooyr commented Oct 19, 2023

See e4879ab for the test

nhooyr added a commit that referenced this pull request Oct 19, 2023
@nhooyr
conn_test.go: Fix TestConcurrentClosePing
28c6709 
Closes #298
Closes #394

The close frame was being received from the peer before we were able to reset our
write timeout and so we thought the write kept failing but it never was...

Thanks @univerio and @bhallionOhbibi
@nhooyr
Copy link
Contributor

nhooyr commented Oct 19, 2023

Fixed in dev, see 28c6709

@nhooyr nhooyr closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr Awaiting requested review from nhooyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.8
Development

Successfully merging this pull request may close these issues.

Ping sometimes causes Close to time out
2 participants
@bhallionOhbibi @nhooyr