Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use the default host names? #335

Open
code-asher opened this issue Aug 2, 2024 · 0 comments
Open

Can we use the default host names? #335

code-asher opened this issue Aug 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@code-asher
Copy link
Member

code-asher commented Aug 2, 2024

Having the set of host names generated by the CLI (coder.<workspace>) and the set of host names generated by the plugin (coder-vscode.<url>--*) causes some confusion when you mix connecting via the remote SSH plugin and connecting through our plugin.

Basically, you can get a different set of settings and recents, because VS Code thinks they are different connections (the host names are different, after all).

I believe we do this for two reasons:

  1. So we can use vscodessh instead of ssh.
  2. To attach an environment variable that allows us to track the connection as a VS Code connection, and not just a regular SSH connection. (Which, by the way, means that connections done with the remote SSH plugin without our plugin will not be tracked as VS Code connections!)

The first is easily solved, the JetBrains plugin already uses the regular ssh command. I think we just have to port the network info command? And this would make it usable with JetBrains as well, so win-win.

The second is trickier. We need some way to identify the connection but I am not sure how. We could track the process on the remote instead, like we do with JetBrains?

@coder-labeler coder-labeler bot added the enhancement New feature or request label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant