Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some special characters in the password are not supported #7008

Open
2 tasks done
doncadavona opened this issue Sep 20, 2024 · 3 comments
Open
2 tasks done

Some special characters in the password are not supported #7008

doncadavona opened this issue Sep 20, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@doncadavona
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Google Chrome
  • Local OS: Windows 11
  • Remote OS: Ubuntu 22.04 server
  • Remote Architecture: x86
  • code-server --version: 4.22.1

Steps to Reproduce

  1. Set the password as "supersecret^" in ~/.config/code-server/config.yaml
  2. Restart code-server by running sudo systemctl restart code-server@$USER
  3. Login in code-server web using the password supersecret^.
  4. Expect that the password is incorrect.

Expected

The password is expected to be correct.

Actual

The password is incorrect.

Logs

No response

Screenshot/Video

No response

Does this bug reproduce in native VS Code?

This cannot be tested in native VS Code

Does this bug reproduce in GitHub Codespaces?

This cannot be tested in GitHub Codespaces

Are you accessing code-server over a secure context?

  • I am using a secure context.

Notes

If this is not a bug, it would be nice to make the password requirements explicitly indicated in the docs.

@doncadavona doncadavona added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Sep 20, 2024
@code-asher
Copy link
Member

It seems to work for me. I tried secret^ in both the config.yaml and as an environment variable.

My config:

bind-addr: 127.0.0.1:8080
auth: password
password: secret^
cert: false

@code-asher code-asher removed the triage This issue needs to be triaged by a maintainer label Sep 23, 2024
@doncadavona
Copy link
Author

Hm, it's weird that it doesn't work on me. I will investigate further. Thanks for confirming it works on yours @code-asher .

@code-asher
Copy link
Member

code-asher commented Sep 24, 2024

Definitely strange. If you check the browser dev tools and look at the network request body, do you see that the password you expect is being sent to the backend? Also, do you see messages on the code-server side about the password being rejected? You should see failed login attempt.

Maybe it is somehow not reading the right config.yaml although I am not sure how that would happen. Do other settings there work, like changing the log level or changing welcome-text (it will show on the login page)? One idea is to try passing --config to make sure it is definitely using the right file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants