-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't install on Alpine using npm due to fortify-headers #6971
Comments
Appreciate you trying to get code-server built on Alpine! Should this be opened with spdlog? It does not seem like we could fix it here, can we? |
For anyone using email and not seeing the edits, I used the wrong punctuation, meant to say "Alpine!" not "Alpine?" 😛 |
You're right, this probably should be opened over on spdlog instead, I'm not familar with Nodejs so I wasn't sure if it had anything to do with code-server or the spdlog bindings used. |
I successfully built spdlog and installed vscode/spdlog, so I'm not sure why I'm having this issue with code-server. Installing the spdlog Node bindings as the superuser also works (thought it might be worth trying because I tried to install code-server globally as root). I get the same inlining errors when I try to locally install code-server too with these steps: |
Oh interesting! In that case maybe this needs to be opened with VS Code. Do you get the same errors building plain VS Code? |
The command we use to build VS Code for code-server is |
I just ran that command in |
Interesting, I am not sure why it would error from code-server then, since we run the same command. 🤔 |
Oh I just realized it is the This is what we do, we |
Following these steps, npm told me to use yarn instead to install dependencies so I just replaced |
That is quite strange. I believe |
Except maybe not if |
I'm also uncertain as to why this happens when installing with both npm and yarn, maybe someone could try to reproduce this too and see if the same issue is present. I'm using Alpine on a Raspberry Pi, although I don't think it's very relevant to the build failing but still worth mentioning. I recall I did install the spdlog package too to see if it would be used for the bindings instead of building from source but it had no effect. |
Is there an existing issue for this?
OS/Web Information
code-server --version
:Steps to Reproduce
doas apk add python3 krb5-dev alpine-sdk bash libstdc++ libc6-compat
doas npm install --global code-server --unsafe-perm
Expected
code-server should be installed successfully
Actual
Can't build spdlog dependency due to
/usr/include/fortify/stdio.h
inlining errorsLogs
Screenshot/Video
No response
Does this bug reproduce in native VS Code?
This cannot be tested in native VS Code
Does this bug reproduce in GitHub Codespaces?
This cannot be tested in GitHub Codespaces
Are you accessing code-server over a secure context?
Notes
Seems like other projects have had this issue as well when LTO are enabled.
fortify-headers
is required byalpine-sdk
.The text was updated successfully, but these errors were encountered: