From e6b2fcc54e57584b938faf289b52e213bb533df8 Mon Sep 17 00:00:00 2001 From: Adam Crownoble Date: Sun, 2 Jul 2023 14:31:29 -0500 Subject: [PATCH 1/4] Use pull_request_target for GitHub workflow action This should fix the problem with the PRs from forked repositories not having access to the repo secrets. Which has caused failures in Codacy runs. --- .github/workflows/rspec.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml index 7cfa799..3ccbb19 100644 --- a/.github/workflows/rspec.yml +++ b/.github/workflows/rspec.yml @@ -3,7 +3,7 @@ name: Ruby on: push: branches: [ main ] - pull_request: + pull_request_target: branches: [ main ] jobs: From 30f205693059d7189ed5c38c87b7be6f85a45f41 Mon Sep 17 00:00:00 2001 From: Adam Crownoble Date: Sun, 2 Jul 2023 14:37:17 -0500 Subject: [PATCH 2/4] Fix for pull_request_target config It seemsed to be skipping PRs from same-repo branches. I believe this will fix it. --- .github/workflows/rspec.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml index 3ccbb19..0658e54 100644 --- a/.github/workflows/rspec.yml +++ b/.github/workflows/rspec.yml @@ -4,7 +4,8 @@ on: push: branches: [ main ] pull_request_target: - branches: [ main ] + types: + - opened jobs: test: From 17b6634b174604477a28b78bba7ed9a8ffa5ba52 Mon Sep 17 00:00:00 2001 From: Adam Crownoble Date: Sun, 2 Jul 2023 14:45:37 -0500 Subject: [PATCH 3/4] Tweak pull_request_target GitHub Action config We want the action to run on each change to a PR, not just the initial open. --- .github/workflows/rspec.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml index 0658e54..23721a3 100644 --- a/.github/workflows/rspec.yml +++ b/.github/workflows/rspec.yml @@ -4,8 +4,7 @@ on: push: branches: [ main ] pull_request_target: - types: - - opened + types: [opened, edited] jobs: test: From 11168b017aac552a6488083a390d900957fc34b7 Mon Sep 17 00:00:00 2001 From: Adam Crownoble Date: Sun, 2 Jul 2023 14:51:54 -0500 Subject: [PATCH 4/4] More tweaks to GitHub Workflow config --- .github/workflows/rspec.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml index 23721a3..186f90d 100644 --- a/.github/workflows/rspec.yml +++ b/.github/workflows/rspec.yml @@ -1,10 +1,6 @@ name: Ruby -on: - push: - branches: [ main ] - pull_request_target: - types: [opened, edited] +on: [push, pull_request_target] jobs: test: