-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store SP in Database #74
Comments
@juliardi I suppose you could store them in a database. There is a lot of sensitive information being stored in databases. I don't see why this would be any different. Whether or not your database is secure is up to you. You should be able to set the config to your liking using the config helper in Laravel. |
@upwebdesign Is this library currently support fetching SP list from database ? |
@juliardi please see the config section of the readme. |
The config section only stated that the SP list stored in the config file, so I conclude currently this library doesn't support fetching SP list from database, but storing the SP list itself in the database is something allowable but would need a modification to this library. Thank you for your answer @upwebdesign. |
@juliardi yes, you are correct. This package does not support DB storage for SP's. This could possibly be a feature request. |
@upwebdesign we are actually in the process of doing this for a piece of software we're working on and are curious if you're open to merging a PR from us for the feature. We're debating about whether or not we want to do this by providing a ServiceProvider eloquent model in the package itself - or providing an abstract class and allowing the user to provide their own implementation as a config variable. If you have a preference let me know as that will effect which way we want to go with this - we would like to get this PR'ed into the package rather than maintaining our own "hard fork" of this package. We would also make sure to provide a test suite that ensures it doesn't break any existing features that it touches. |
@jrgilman, involving the database with this package would expose a potential breaking change. If a database is considered, all SP information should be able to be stored in the database while still allowing for .env/config implementation. If your team would like to tackle a DB approach, that would be cool. |
Is it possible to store the list of Service Provider in the database and grab it from there whenever someone login/logout ?
Or is it a security issue?
The text was updated successfully, but these errors were encountered: