Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not really ORM-Agnostic #75

Open
HoneyryderChuck opened this issue Sep 14, 2016 · 2 comments
Open

Not really ORM-Agnostic #75

HoneyryderChuck opened this issue Sep 14, 2016 · 2 comments

Comments

@HoneyryderChuck
Copy link

This gem doesn't work for Sequel, not outside of the box at least. The EachValidator object is AFAIK only defined in Rails, and is not part of the ActiveModel spec.

One could remove the ORM-agnostic description (unless there's morethan ActiveRecord this gem supports) or build a validation method to be added to Sequel::Model when loading the ValidationHelpers plugin.

@jufemaiz
Copy link

@TiagoCardoso1983 are you correctly including ActiveModel::Validations?

http://api.rubyonrails.org/classes/ActiveModel/Validator.html

@HoneyryderChuck
Copy link
Author

sequel has its own validations plugin, and therefore doesn't use activemodel validations. If this gem requires them, then it is neither ORM-agnostic nor Rails-agnostic. Am I correct inferring this? Because if so, you could at least update the "ORM-agnostic" disclaimer in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants