Backend validation for POST /leads endpoint #144
Labels
Comments
|
@galbwe Could you assign this issue to me? |
|
Hi @kaleeaswari would you rather work on this or #201 ? Due to the number of Hacktoberfest contributors, I'm trying to assign people to one issue at a time until they have a PR ready. |
|
@kaleeaswari do you want to be assigned now that #201 is closed? |
|
Hey Wes,
I started working on this,
Return tags in the /leads endpoint #199
I can take #144 after this.
…On Thu, Oct 21, 2021 at 9:56 AM Wes Galbraith ***@***.***> wrote:
@kaleeaswari <https://github.com/kaleeaswari> do you still want to be
assigned?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5MXAWH7BVUH3ILI4DSBYDUH6JANANCNFSM5FKYBZZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Okay great. Do you mind leaving a comment on #199 saying you want to be assigned? At the moment the repo doesn't let me assign you an issue unless you have commented on it. |
|
Hi Wes,
Can you mention the location to look for api logs/print statements.?
…On Thu, Oct 21, 2021 at 8:06 PM Wes Galbraith ***@***.***> wrote:
Okay great. Do you mind leaving a comment on #199
<#199> saying you
want to be assigned? At the moment the repo doesn't let me assign you an
issue unless you have commented on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5MXATOKST3KK7SOM7EVY3UIAQOFANCNFSM5FKYBZZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Hello Wes,
I am running the flask lint check. It passes in the local but fails in the
repo. Can you help me fix this? (#207)
On Thu, Oct 21, 2021 at 9:25 PM Kaleeaswari S ***@***.***>
wrote:
… Hi Wes,
Can you mention the location to look for api logs/print statements.?
On Thu, Oct 21, 2021 at 8:06 PM Wes Galbraith ***@***.***>
wrote:
> Okay great. Do you mind leaving a comment on #199
> <#199> saying you
> want to be assigned? At the moment the repo doesn't let me assign you an
> issue unless you have commented on it.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#144 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AF5MXATOKST3KK7SOM7EVY3UIAQOFANCNFSM5FKYBZZQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
|
If you are running the app in docker compose, you should be able to access the container logs with |
|
The check that is failing is the formatter. You should be able to fix it by running |
|
Running this command doesn't alter any of my files.
…On Fri, Oct 22, 2021 at 6:32 AM Wes Galbraith ***@***.***> wrote:
The check that is failing is the formatter. You should be able to fix it
by running ./scripts/format.sh in the backend directory.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5MXAU34LQGB3S6ADJEDATUICZ3VANCNFSM5FKYBZZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Hi @galbwe, if there is no pull request, can I work on this issue? |
Open
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add the following validation to the POST
/leadsendpoint. Feel free to add marshmallow or pydantic as a dependency if it simplifies matters.(###) ###-####or###-####The text was updated successfully, but these errors were encountered: