-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to function components & React Hooks #135
Comments
@olena-ageyeva do you want to help with this in early 2020? We are going to try to release everything on Jan 17, so ideally we'd have this sorted out a week and a half before. |
@thadk Sure. I'd be delighted to. You'd like it to be completed by January 6-7sh, right? It looks like a lot of refactoring work in a short time, but I agree it will significantly simplify the code and it does make sense to do so before the release. Will start working on it now. |
Wow, great, whatever you think you can contribute will help. I just added you to the project, maybe we can work on a (feel free to create) An early version to show everyone the concept on Tue Jan 7 when we meet next would be excellent–I'm sure folks will need a bit of introduction to the new way of managing variables, etc. |
New way to manage state is proposed in #142 which can be function component and/or hooks-compatible. |
If you want to work on this for one of the other files: Reading this code around the |
cc: @olena-ageyeva @linesbetween I updated this issue if you'd like to help on it. We also have the example as in the last comment. |
Related PR: #294 |
The code organization would be a lot clearer if we used function components and React Hooks instead of class components.
We now have
useUserState
anduseUserStateActions
hooks to access the state of the app and manipulate it, respectively.Converted
src/pages/*
to function components?:Other major components:
src/components/file-upload.tsx
(can be separated into individual components)Feel free to create new component files as you go.
The text was updated successfully, but these errors were encountered: