Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination #60

Open
allthesignals opened this issue Dec 17, 2014 · 5 comments
Open

Pagination #60

allthesignals opened this issue Dec 17, 2014 · 5 comments

Comments

@allthesignals
Copy link
Contributor

We want the results page to paginate results instead getting everything from the server.

@Mr0grog has started this work, which can be seen in pull request #59. With only a few minor issues, this seems to be a good start for pagination in the front end.

We may need more information. The Backbone model needs to stop asking for data when it reaches the end of the queryset. @brucegarro, any thoughts?

@Mr0grog
Copy link
Contributor

Mr0grog commented Dec 17, 2014

We may need more information, like total number of pages.

FWIW, that’s already in there. In the results, it’s the key called pages.

@allthesignals
Copy link
Contributor Author

@Mr0grog Ah, I forgot &no_map=true in the URL params. That's why I wasn't seeing it. Thank you for pointing that out.

@brucegarro
Copy link
Contributor

FYI, I had to to UB FWIW TBH.

@allthesignals
Copy link
Contributor Author

@brucegarro this is a conversation about using Backbone.paginator with Marionette: http://stackoverflow.com/questions/11519061/how-to-handle-pagination-with-backbone-marionette/19222183#19222183

@allthesignals
Copy link
Contributor Author

I just implemented a rough start for front end pagination in a new branch. Currently, it pulls new pages of data from the server after clicking "next" in the results page. Some issues:

  • New results need to be appended to the existing view, not new pages.
  • Masonry breaks when it's a paginated view. Masonry has an append method, but I don't know how it works exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants