Skip to content
This repository has been archived by the owner on Sep 19, 2018. It is now read-only.

Show validation errors for URLs longer than 200 chars in the "Add event" form #375

Open
mitio opened this issue Oct 2, 2014 · 1 comment

Comments

@mitio
Copy link
Member

mitio commented Oct 2, 2014

I just had an event with a broken "More information" URL, because it seems to have been silently truncated at some point to 200 chars.

200 chars is not that long for a URL. A more sensible limit can be set to 1024 or even near 2k.

However, even if the limit stays at 200 chars, a validation error should tell the user that his URL is too long and has to be shortened in order to fit. The error can even mention a URL shortening service like bitly.com.

@mitio mitio changed the title Show validation errors if a too long URL is entered in the "Add event" form Show validation errors for URLs longer than 200 chars in the "Add event" form Oct 2, 2014
@goranche
Copy link
Contributor

goranche commented Oct 2, 2014

thanks for the issue, I agree on the validation, we will look into it (maybe care to fork the repository, fix it yourself and submit a pull request? 😉 )

but about the 1+k URLs? I don't agree with you on that one, 200 characters should be enough for a URL, if you ask me, so I doubt that limit will be increased... sure, one might include tracking info in get params and various stuff like that, but that can be handled otherwise (you already mentioned shortening services), so it wouldn't really make sense

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants