Use in-place commands when possible to increase speed #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
- This is for 20m rows and 20 columns, 9 executions of generate log(x) - Current time is median time is 4-5 seconds, raising bar to 10 seconds to have some slack
- Julia nightly builds were slower
gergelyattilakiss
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For
generate,egenandreplace, removedsetdffrom the end to avoid copying the entire df.Related Issues
Number of Passing Unit Tests
474/474
Also see
test/speed.jl(I should turn this into a unit test!)Checklist
Tests
] testruns without errorsDocumentation
No change to API, but speed benchmarks have been updated.