Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: handle missing values in regression formula #129

Closed
korenmiklos opened this issue Jul 4, 2024 · 2 comments
Closed

bug: handle missing values in regression formula #129

korenmiklos opened this issue Jul 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@korenmiklos
Copy link
Member

No description provided.

@korenmiklos korenmiklos added this to the v0.4-rc milestone Jul 4, 2024
@korenmiklos korenmiklos added the bug Something isn't working label Jul 4, 2024
@gergelyattilakiss
Copy link
Collaborator

started working on it I want to patch regress through the same function as summarize. Noticed we did not used Kezdi.regress previously.

@korenmiklos
Copy link
Member Author

Great. Pls create a branch for it and push frequently. The trick with regress is that we cannot drop missing variable by variable. Get all the variables out of the formula, and if any of the variables is !isvalue, drop the entire row. So.

DataFrame(x1 = [1, 2, missing, 4], x2 = [5, missing, 7, 8]) should become DataFrame(x1 = [1, 4], x2 = [5, 8]) and not DataFrame(x1 = [1, 2, 4], x2 = [5, 7, 8])

(Actually here is your first test case.)

@gergelyattilakiss gergelyattilakiss self-assigned this Jul 9, 2024
korenmiklos added a commit that referenced this issue Jul 10, 2024
314 tests pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants