Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package upgrade done (#10) #11

Merged
merged 2 commits into from
Jul 8, 2024
Merged

package upgrade done (#10) #11

merged 2 commits into from
Jul 8, 2024

Conversation

ct-dixit
Copy link
Member

@ct-dixit ct-dixit commented Jun 27, 2024

Commit Checklist

  • Remove UNUSED comment code
  • Remove any logging like console.log
  • Remove all warnings and errors while build
  • Check vulnerabilities
  • Make sure build for production is working. Try running command for prod build in local.
  • Fix prettier: npx prettier --write .
  • Fix eslint: npx eslint src\ --fix command
  • Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
  • WCAG

General

  • Follow import structure. module/third-party/files/component/style/types/asset
  • Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
  • Before adding custom style follow our pre-built components/elements

@ct-dixit ct-dixit requested a review from phoenixcoded20 July 8, 2024 05:58
@phoenixcoded20 phoenixcoded20 merged commit b2c3558 into master Jul 8, 2024
@phoenixcoded20 phoenixcoded20 deleted the stage-4.1.0 branch July 8, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants