Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Entity is never used #25

Open
thkoch2001 opened this issue May 26, 2014 · 3 comments
Open

User Entity is never used #25

thkoch2001 opened this issue May 26, 2014 · 3 comments

Comments

@thkoch2001
Copy link

Hi,

we just integrated CCDNUserSecurityBundle into a legacy application where we do not yet use the FOSUserBundle, nor do we have a (doctrine) entity for our user class.

So we where stuck a bit, because we did not now, what value we could provide for this configuration key:

ccdn_user_security:
    entity:
        user:
            class: Acme\YourUserBundle\Entity\User # Required

After greping through the code we came to the conclusion that this configuration value is never used. So we left the example value in there and everything worked fine.

Is it right, that this configuration key should be removed from CCDNUserSecurityBundle

@reecefowell
Copy link
Member

I thought it was being used. Try grepping

entity.user.class%

@thkoch2001
Copy link
Author

Hi reecefowell,

thank you for replying, but have you tried to grep for this string yourself? There's only this line in DependencyInjection/CCDNUserSecurityExtension.php:

$container->setParameter('ccdn_user_security.entity.user.class', $config['entity']['user']['class']);

It doesn't seem that the container parameter is ever used again.

@reecefowell
Copy link
Member

I took another look and i think your correct.

If you want to make a PR to remove this then please go ahead as i don't think it is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants