Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop-rspec #293

Closed
BrianHawley opened this issue Jul 6, 2021 · 5 comments
Closed

Update rubocop-rspec #293

BrianHawley opened this issue Jul 6, 2021 · 5 comments
Assignees
@f-moya

Comments

@BrianHawley
Copy link

BrianHawley commented Jul 6, 2021 •
edited
Loading

Update rubocop-rspec to 2.2.0 In channel 1-12-1, because of Ruby 2.4 compatibility. Update rubocop-rspec to 2.4.0 in channel 1-18-3.

Only mentioned those specific channels because they're not yet released.
@BrianHawley
Copy link
Author

This might be considered a dup of #271.

@f-moya
Copy link

f-moya commented Jul 6, 2021

Feel free to open prs for rubocop-rspec, I won't be performing that update this week but I could merge work.

This was referenced Jul 6, 2021
Merged
Merged
@BrianHawley
Copy link
Author

@fede-moya I opened the PRs to get channels 1-12-1 and 1-18-3 up to date.

f-moya pushed a commit that referenced this issue Jul 6, 2021
@BrianHawley
Update channel 1-18-3 (#296)
f8084d4 
Update all plugins with bundle update; all Ruby 2.5-3.0 compatible.

[Fixes #272, #293]
@BrianHawley
Copy link
Author

@fede-moya as with the rubocop-rails update issue, the channel that I personally need the updates for the most is 1-12-1, so PR #295 is the critical one for me to get in there.

f-moya pushed a commit that referenced this issue Jul 6, 2021
@BrianHawley
Make channel 1-12-1 (mostly) Ruby 2.4 compatible (#295)
b19d961 
- Update plugins to the last Ruby 2.4 compatible versions.
- Be specific about the versions in Gemfile, so bundle update works.
- Do the bundle update.
- Don't downgrade ruby-i18n and ruby-graphql; the listed versions are
  not compatible with Ruby 2.4, so don't use them if using Ruby 2.4.

[Fixes #272, #291, #293]
@f-moya
Copy link

f-moya commented Jul 6, 2021

@BrianHawley done ! Thank you for opening prs 👏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f-moya f-moya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrianHawley @f-moya