Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling suggestion for AfterSuite Hook #4466

Closed
laxmikant-parate opened this issue Aug 22, 2024 · 2 comments · Fixed by #4476
Closed

Error handling suggestion for AfterSuite Hook #4466

laxmikant-parate opened this issue Aug 22, 2024 · 2 comments · Fixed by #4476

Comments

@laxmikant-parate
Copy link

What are you trying to achieve?

!!! This is not a bug, just a suggestion !!!

Suppose I have 2 scenarios and 1 AfterSuite hook in a file and while execution both the scenarios passed but the AfterSuite hook failed, it shows as FAIL | 2 passed, 1 failed. This creates confusion, it may better show as 2 passed and the AfterSuite hook failed.
@kobenguyent kobenguyent mentioned this issue Sep 2, 2024
Merged
5 tasks
@kobenguyent kobenguyent linked a pull request Sep 2, 2024 that will close this issue
feat(cli): print failed hooks #4476
Merged
5 tasks
@mirao
Copy link
Contributor

mirao commented Dec 11, 2024

I'm afraid the bug fix is in a conflict with the behavior I would expect, see my comment #4476 (comment)

@mirao
Copy link
Contributor

mirao commented Dec 13, 2024

I'm afraid the bug fix is in a conflict with the behavior I would expect, see my comment #4476 (comment)

It was fixed in #4633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): print failed hooks codeceptjs/CodeceptJS
2 participants
@mirao @laxmikant-parate