Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ForAttributeWithMetadataName() #54

Merged
merged 11 commits into from
Aug 10, 2024
Merged

Use ForAttributeWithMetadataName() #54

merged 11 commits into from
Aug 10, 2024

Conversation

crwsolutions
Copy link
Contributor

See cookbook.

This utility method is at least 99x more efficient than SyntaxProvider.CreateSyntaxProvider, and in many cases even more efficient

But on top of that, some code could be removed. Which has made things a bit easier.

@ChristianSauer
Copy link
Collaborator

Wow, that looks really nice.
Is the API new? When I originally wrote this (dotnet 6?) I think this API did not exist

@crwsolutions
Copy link
Contributor Author

Yes, it was introduced with the version 4.3.1 of Microsoft.CodeAnalysis.

@ChristianSauer ChristianSauer merged commit c1ee637 into codecentric:master Aug 10, 2024
3 checks passed
@crwsolutions crwsolutions deleted the feature/use-ForAttributeWithMetadataName branch August 10, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crwsolutions @ChristianSauer