What I learned on my first ever merged commit to the Frontend #146
Unanswered
bengineerdavis
asked this question in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
What I Learned merging PR 123:
Destructuring in JavaScript and how to alias imported variables from a JSON string (such as the output from Axios).
MaterialUI does a great job of abstracting CSS and HTML styling and structure directly inside JSX and the React framework. We can use their API within loops and accept data within JSX component tags, and from other data structures.
When dealing with a forked repository, I found that it wasn’t a given that git push or git pull would also pull down from, or push up to, the upstream “frontend” repo. When the upstream is ahead of the fork, I can use git rebase in the “main” branch to fast forward my local copy of the repository so my changes sync properly and avoid potential conflicts.
ESLint has a very flexible json configuration file for linting rules, allowing snake-cased variables inside JavaScript!
There is no such thing as a small change--be prepared to have strategic discussions and merge community input into any PR as much as possible.
Draft PRs are a neat feature of GitHub that can help me “reserve” a proposed merge I want to do and also give me time to improve on it before sending my changes for a merge approval. I can put out code in a rough draft form first and then come back to polish it up later. It’s a nice way to help me edit my own work and save maintainers time reviewing code I can probably fix myself.
I didn’t know I could merge a PR into my PR and then merge THAT PR. That was cool!
I really like how JSX let’s me think within the HTML of a doc and makes it really easy to pass in variables, almost like a template.
Beta Was this translation helpful? Give feedback.
All reactions