Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gazebo_attache_plugin - as dependency #29

Open
gheorghelisca opened this issue Aug 3, 2016 · 5 comments
Open

gazebo_attache_plugin - as dependency #29

gheorghelisca opened this issue Aug 3, 2016 · 5 comments

Comments

@gheorghelisca
Copy link
Contributor

  • needs to be compiled relative to the gazebo version which runs
  • i propose to:
    • have it as dependency and of "longterm_fetch_and_place"
    • from "longterm_fetch_and_place" load the plugin and update the "GAZEBO_PLUGIN_PATH"
@fairlight1337
Copy link
Contributor

Yeah, maybe we can put it into cram_gazebo as that's also where @mpomarlan's visibility plugin resides; also, then it gets compiled rather than shipped as binary (which what is the case right now, which is super bad practice - courtesy to myself).

The repository in question is this: gazebo_attache_plugin.

Thanks for putting together the issue.

@mpomarlan
Copy link
Contributor

mpomarlan commented Aug 4, 2016

I'm assigning @bbrieber to this as well, because he had a helpful idea: https://github.com/code-iai/iai_gazebo_utils which is a repository for such gazebo plugins.

The plan is to move my gazebo_visibility_ros plugin there soon; I'd suggest we put gazebo_attache_plugin there as well.

@fairlight1337
Copy link
Contributor

Good idea. I'll see after moving it there as well. Do we need to make ROS packages out of those to make them accessible via some Gazebo plugin path? Or can we have them available somehow differently?

I imagine that having them as ROS packages places the compiled shared objects somewhere in the devel folder; this is per definition searched by Gazebo, isn't it? That would safe us from having to define custom install targets.

@mpomarlan
Copy link
Contributor

Having them as ROS packages seems the way to go. Both plugins use ROS anyway.

@fairlight1337
Copy link
Contributor

True. I'll see after getting it in there if that's what we're doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants