-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player Size: full window with theater mode hides player after search #1555
Comments
@dojoVader Can you elaborate please, changing to what value? It's always null for me, setting it to 10px / 20px etc.. doesn't solve. |
@sarim apologies for not explaining So I debugged it when you focus out, it tries to read a property from DataSet but it comes back with a null, when a null is set, this hides the player, Here is a screenshot for more clarity. Source: general.js |
@sarim I encountered the same issue, but when I disabled and enabled it to replicate it, I didn't get the issue again, can you confirm this on your side, I'm trying to replicate the issue, to trace what's setting it as null. |
Thank you
…On Tuesday, 7 February 2023, Okeowo Aderemi ***@***.***> wrote:
@sarim <https://github.com/sarim> apologies for not explaining
So I debugged it when you focus out, it tries to read a property from
DataSet but it comes back with a null, when a null is set, this hides the
player, Here is a screenshot for more clarity.
Source: general.js
Line: 550
[image: image]
<https://user-images.githubusercontent.com/789578/217210086-2fa79515-5c88-4306-832f-8cd3a70c3529.png>
—
Reply to this email directly, view it on GitHub
<#1555 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A37QRWDLL3UI3CFFB2ELV4TWWIK6ZANCNFSM6AAAAAAUM766BM>
.
You are receiving this because you are subscribed to this thread.Message
ID: <code-for-charity/ImprovedTube-for-YouTube/issues/1555/1420483617@
github.com>
|
@dojoVader ah you're running it from source? I didn't dig that deeper.
Issue still present on my side. |
@sarim I am going to run the extension from the store and confirm it today. |
@dojoVader currently the same |
@ImprovedTube @sarim Thanks click full_window causes the bug. |
@ImprovedTube it-position-header-original contains a null, that null is used to set the it-position-header, which causes the player to disappear, rather than null Do we default to a "normal" or "static" ? Here is a video with a fix applied, let me know what you think https://www.awesomescreenshot.com/video/14622583?key=30182d888bc763c9b7ca072aa99b3e95 |
@ImprovedTube waiting for feedback, this code shows why it's failing so I am asking if we switch the default value from null to either "normal" or "static". |
@dojoVader Another question. I'm not telling improvetube to change header style, then why the function is getting called? I think the function shouldn't even be called if there is no setting set in appearance->header section. |
thank you guys! please make a pull request anytime, for any fix or quick fix. The bigger picture:
"Full window" sets header size 0px.
Yes! conditions for this function to run:
BTW: Ultimately we can handle all input & shortcuts at once: #1565
#1685 |
For quick fix I added this with a tampermonkey script document.querySelector("html").setAttribute("it-header-position", 'normal'); This seems to solve the problem for now. |
exactly. While we should also check aand the quick-fix for us to upload asap can be @dojoVader's or better wrapping it in another if (headerPos) {}(+ exchanging line 564 & 565 for a little optimisation.. https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/bf7c3bc21a1848d75d44a0211e1d58e167b79f47/content-scripts/extension-context/youtube-features/general/general.js#L564 ) |
" |
⚬ BUG:
If you click on youtube search box, Then click outside somewhere, video player gets hidden.
⚬ HOW:
⚬ EXPECTED (/preferred) behavior:
Video keep showing.
⚬ Screenshots:
Screencap:
Screenshot.2023-02-01.04.38.15.mp4
Setup:
⚬ ImprovedTube Version: 4.0.17
⚬ Browser: Google Chrome 109.0.5414.120
⚬ Settings:
⚬ OS: Windows 11 22H2 OS Build 22621.1194
⚬ Device: Desktop Computer
The text was updated successfully, but these errors were encountered: