Commits on Nov 21, 2024

1. sql/stats: fix panic catching in the stats cache, show histogram …

   This commit removes a top-level panic catcher from GetTableStats in the stats
   cache, and instead adds a couple of lower level panic catchers. The problems
   with the top-level catcher are:
   - There are other entry points into the stats cache besides GetTableStats, so
     it missed some cases.
   - Because the stats cache contains shared state, condition variables, mutexes,
     etc, it was possible to get into a scenario where a panic would bypass
     important logic (such as broadcasting when a resource is available), but the
     panic would be caught at the top level and leave the cache in a bad state.
   The new panic catchers are below the level of this shared state manipulation,
   but also ensure that all paths into the stats cache that might panic are
   covered.
   
   This commit also adds panic catching to SHOW HISTOGRAM so that decoding errors
   do not crash the process when running SHOW HISTOGRAM.
   
   Fixes #135940
   
   Release note (bug fix): Fixed an issue where corrupted table statistics could
   cause the cockroach process to crash.

   

   rytaft committed Nov 21, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 572ce71
   • Browse repository at this point

   Copy the full SHA

   572ce71 View commit details

   Browse the repository at this point in the history