logictest: separate out stmts in upsert test #135213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it so that we execute each query via a separate logic test directive in `upsert_non_metamorphic` test. My hope is that this will make the test consume a bit less resources so that we don't hit timeouts under race. I confirmed that disabling metamorphic randomization appears to work correctly in this case. If we still see timeouts on this file under race, I'd consider skipping this test in such config (which was recently reverted in 18bd696). Release note: None
yuzefovich
added
backport-24.2.x
yuzefovich
requested review from
a team and
rytaft
and removed request for
a team
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it so that we execute each query via a separate logic test directive in
upsert_non_metamorphictest. My hope is that this will make the test consume a bit less resources so that we don't hit timeouts under race. I confirmed that disabling metamorphic randomization appears to work correctly in this case. If we still see timeouts on this file under race, I'd consider skipping this test in such config (which was recently reverted in 18bd696).Fixes: #135166.
Release note: None