roachtest: wait longer for token return #135211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbaptist
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
|
It may need to be even longer, judging by the partition run. Have you validated the 5 min duration is sufficient? |
|
No - I can set this even longer, let me test this out, so hold off reviewing until I can run a couple of successful runs against it. |
Previously tokens needed to be returned within 5 seconds of stopping the workload. This resulted in failures in some of the perturbation/* tests when using apply-to-all for replAC. This change bumps the window to 5 minutes to allow more times for the tokens to be returned. Epic: none Release note: None
andrewbaptist
force-pushed
the
2024-11-14-allow-longer-token-return
branch
from
4f1d077
to
469c48d
Compare
|
Is this ready for review @andrewbaptist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tokens needed to be returned within 5 seconds of stopping the workload. This resulted in failures in some of the perturbation/* tests when using apply-to-all for replAC. This change bumps the window to 5 minutes to allow more times for the tokens to be returned.
Epic: none
Release note: None