Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump Pebble to 97771076bfa0 #135208

Merged

Conversation

RaduBerinde
Copy link
Member

And switch to using crlib/fifo.

Changes:

  • 97771076 bump crlib, switch to crlib/fifo
  • 028cc89e db: log additional WAL details during replay
  • eef539c0 tool: use First in scan if no start key is provided
  • 5f81af55 colblk: ensure test coverage of UintBuilder array doubling loop

Release note: none.
Epic: none.

Copy link

blathers-crl bot commented Nov 14, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

And switch to using `crlib/fifo`.

Changes:

 * [`97771076`](cockroachdb/pebble@97771076) bump crlib, switch to crlib/fifo
 * [`028cc89e`](cockroachdb/pebble@028cc89e) db: log additional WAL details during replay
 * [`eef539c0`](cockroachdb/pebble@eef539c0) tool: use First in scan if no start key is provided
 * [`5f81af55`](cockroachdb/pebble@5f81af55) colblk: ensure test coverage of UintBuilder array doubling loop

Release note: none.
Epic: none.
@RaduBerinde RaduBerinde force-pushed the radu/pebble-master-97771076bfa0 branch from 205ac2f to c983678 Compare November 14, 2024 22:03
@RaduBerinde
Copy link
Member Author

TFTR!

bors r+

@craig craig bot merged commit 6610d70 into cockroachdb:master Nov 15, 2024
23 checks passed
@RaduBerinde RaduBerinde deleted the radu/pebble-master-97771076bfa0 branch November 15, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants