Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/changefeedccl: TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart failed #134903

Closed
github-actions bot opened this issue Nov 11, 2024 · 2 comments · Fixed by #135194
Closed
Assignees
Labels
A-cdc Change Data Capture branch-master Failures and bugs on the master branch. branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc

Comments

@github-actions
Copy link

github-actions bot commented Nov 11, 2024

ccl/changefeedccl.TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart failed on master @ 24ac6d76b5c16eca9f29611779f808b2394188ed:

=== RUN   TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart3313006657
    test_log_scope.go:76: use -show-logs to present logs inline
    helpers_test.go:962: making enterprise feed factory
    helpers_test.go:976: pgURL enterprise root
    changefeed_test.go:6572: 
        	Error Trace:	pkg/ccl/changefeedccl/changefeed_test.go:6572
        	Error:      	Received unexpected error:
        	            	still waiting for job status; current running
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.(*jobFeed).WaitForStatus.func1
        	            	  | 	pkg/ccl/changefeedccl/testfeed_test.go:458
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError.func1
        	            	  | 	pkg/testutils/soon.go:71
        	            	  | github.com/cockroachdb/cockroach/pkg/util/retry.ForDuration
        	            	  | 	pkg/util/retry/retry.go:213
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError
        	            	  | 	pkg/testutils/soon.go:77
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsSoonError
        	            	  | 	pkg/testutils/soon.go:47
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.(*jobFeed).WaitForStatus
        	            	  | 	pkg/ccl/changefeedccl/testfeed_test.go:449
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
        	            	  | 	pkg/ccl/changefeedccl/changefeed_test.go:6572
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1689
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_amd64.s:1695
        	            	Wraps: (2) still waiting for job status; current running
        	            	Error types: (1) *withstack.withStack (2) *errutil.leafError
        	Test:       	TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart3313006657
--- FAIL: TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart (178.30s)

Parameters:

  • attempt=1
  • run=1
  • shard=3
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/cdc

This test on roachdash | Improve this report!

Jira issue: CRDB-44286

@github-actions github-actions bot added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc labels Nov 11, 2024
@blathers-crl blathers-crl bot added the A-cdc Change Data Capture label Nov 11, 2024
@asg0451
Copy link
Contributor

asg0451 commented Nov 14, 2024

I managed to repro this locally after running it thousands of times and got the attached stack trace and test.log. it seems to indicate that the feed is still waiting on data from kv and that it hasnt yet hit its configured end time. can someone from kv take a look at it?
Screenshot 2024-11-14 at 11 19 51 AM

goros.txt
test.log

@asg0451 asg0451 removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Nov 14, 2024
asg0451 added a commit to asg0451/cockroach that referenced this issue Nov 14, 2024
The
TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
test has been flaky, on kv's advice I am
increasing its timeout.

Fixes: cockroachdb#134903
Fixes: cockroachdb#134916

Release note: None
@asg0451 asg0451 assigned asg0451 and unassigned pav-kv Nov 14, 2024
asg0451 added a commit to asg0451/cockroach that referenced this issue Nov 14, 2024
The
TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
test has been flaky, on kv's advice I am
increasing its timeout.

Fixes: cockroachdb#134903
Fixes: cockroachdb#134916

Release note: None
asg0451 added a commit to asg0451/cockroach that referenced this issue Nov 14, 2024
The
TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
test has been flaky, on kv's advice I am
increasing its timeout.

Fixes: cockroachdb#134903
Fixes: cockroachdb#134916

Release note: None
@asg0451 asg0451 added the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Nov 14, 2024
asg0451 added a commit to asg0451/cockroach that referenced this issue Nov 14, 2024
The
TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
test has been flaky, on kv's advice I am
increasing its timeout.

Fixes: cockroachdb#134903
Fixes: cockroachdb#134916

Release note: None
asg0451 added a commit to asg0451/cockroach that referenced this issue Nov 14, 2024
The TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
test has been flaky, on kv's advice I am increasing its timeout.
I'm also enabling verbose changefeed logging to help diagnose future issues here.

Part of: cockroachdb#134903
Part of: cockroachdb#134916

Release note: None
asg0451 added a commit to asg0451/cockroach that referenced this issue Nov 14, 2024
The
TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
test has been flaky, on kv's advice I am
increasing its timeout. I'm also enabling verbose
changefeed logging to help diagnose future issues
here.

Part of: cockroachdb#134903
Part of: cockroachdb#134916

Release note: None
craig bot pushed a commit that referenced this issue Nov 15, 2024
135194: changefeedccl: bump test timeout r=wenyihu6 a=asg0451

The
TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
test has been flaky, on kv's advice I am
increasing its timeout. I'm also enabling verbose
changefeed logging to help diagnose future issues
here.

Fixes: #134903
Fixed: #134916

Release note: None


135233: vecindex: add recall test command r=drewkimball a=andy-kimball

The new "recall" test command computes the percentage of search results that are true nearest results. This is a standard measure of index and search quality.

Epic: CRDB-42943

Release note: None

135257: roachtest: disable clock offset checks in ptp test r=tbg a=tbg

I'm not sure if they "caught" the test messing with the system clock (it
doesn't exactly seem like it[^1]), but this can't hurt either.

[^1]: #134760 (comment)

`./pkg/cmd/roachtest/roachstress.sh -c 1 ptp` passed.

Epic: none
Release note: None


Co-authored-by: Miles Frankel <[email protected]>
Co-authored-by: Andrew Kimball <[email protected]>
Co-authored-by: Tobias Grieger <[email protected]>
@craig craig bot closed this as completed in df3f5cf Nov 15, 2024
Copy link

blathers-crl bot commented Nov 15, 2024

Based on the specified backports for linked PR #135194, I applied the following new label(s) to this issue: branch-release-24.3. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 label Nov 15, 2024
blathers-crl bot pushed a commit that referenced this issue Nov 15, 2024
The
TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart
test has been flaky, on kv's advice I am
increasing its timeout. I'm also enabling verbose
changefeed logging to help diagnose future issues
here.

Fixes: #134903
Fixes: #134916

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture branch-master Failures and bugs on the master branch. branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants