Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Machines -> Console -> Desktop Viewer enhanced to support vnc:// urls #1775

Open
paul-hammant opened this issue Aug 20, 2024 · 3 comments

Comments

@paul-hammant
Copy link

Pertinent RFC - https://www.rfc-editor.org/rfc/rfc7869.html

From the UI for a VM when looking at the console, and about to launch "desktop viewer"

image

For some reasons for me on my Ubuntu 24.04 machine with virt-viewer installed and orginarily working on it's own, when I click the blue launch button, a download is initiate of a file called download with no .vv suffix for some reason. Chrome doesn't know what do to with it so it is just placed in ~/Downloads. It could bebetter as <vmname>.vv instead of download.

Point of the feature request: IMO it would be best if it were: vnc://<hostname>:590x/more-args-for-that-vm

@garrett
Copy link
Member

garrett commented Sep 2, 2024

I thought for sure it was using a .vv extension for this file. This is probably either a regression or some change in browser behavior.

As far as vnc://, that still isn't supported in browsers.

Status of This Memo

This document is not an Internet Standards Track specification; it is
published for informational purposes.

I tried it again in both Firefox and Chrome just now and it does nothing but redirect to a search engine. We can't add support for that in Cockpit until browsers actually support it first. (This is why the .vv file format exists, as a launcher workaround to not having a vnc:// URL.)

@paul-hammant
Copy link
Author

Good point.

@jelly
Copy link
Member

jelly commented Sep 2, 2024

Fixing the filename would be nice, the download code is located in fileDownload, currently it uses an iframe to download with a data url (The notes in the code says this is due to CSP issues with a normal anchor link). This likely? does not support naming the downloaded filename.

Maybe we can switch the button to be a real anchor with a download attribute which is $vmname.vv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants