Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly support opening in browser tabs #545

Open
garrett opened this issue Jun 10, 2024 · 3 comments · May be fixed by #612
Open

Properly support opening in browser tabs #545

garrett opened this issue Jun 10, 2024 · 3 comments · May be fixed by #612
Labels
bug Something isn't working

Comments

@garrett
Copy link
Member

garrett commented Jun 10, 2024 •
edited
Loading

When middle-clicking on a folder (or control-clicking), it opens in a new tab, but the directory is not the directory that was clicked on. The new tab is the previous directory, which is unexpected.
@garrett garrett added the bug Something isn't working label Jun 10, 2024
leomoty added a commit to leomoty/cockpit-files that referenced this issue Jun 28, 2024
@leomoty
Properly open selected folder on middle click
426bdc9 
Fixes cockpit-project#545
@leomoty leomoty linked a pull request Jun 28, 2024 that will close this issue
Open
leomoty added a commit to leomoty/cockpit-files that referenced this issue Jun 28, 2024
@leomoty
Properly open selected folder on middle click
1c6783f 
Fixes cockpit-project#545
leomoty added a commit to leomoty/cockpit-files that referenced this issue Jun 28, 2024
@leomoty
Open selected folder on middle or ctrl click
350654e 
Fixes cockpit-project#545
@garrett
Copy link
Member Author

garrett commented Jul 11, 2024

Switching to links in the pathbar as mentioned in #641 should fix the issue for the pathbar, at least.

Files will be tricker due to other necessary interactions.

@jelly
Copy link
Member

jelly commented Oct 1, 2024

What more is expected here? Note that we do run another bridge in a new window so this will be fairly expensive.

@garrett
Copy link
Member Author

garrett commented Oct 2, 2024

It should have the shell in the new tab after middle-clicking on a link. ("Fairly expensive" is really relative.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly open selected folder on middle click leomoty/cockpit-files
2 participants
@garrett @jelly