-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic highlighting? #34
Comments
Waiting for the semantic token lsp proposal to finalize, and the implementation in coc.nvim :) |
Thank you, I currently run with both this and omnisharp-vim, effectively running two versions of the server. Which is fine as it doesn't cause any performance problems. But I'd much rather be able to run just this. The other problems I have are: I can't jump to the definition/type/etc if it's another library. With omnisharp-vim I can jump to e.g. .NET code and it gives me the function signature at minimum with documentation, or if it's available the full source. E.g. if I use go to definition on Can this be added? Function signatures just don't work? If I start filling out a function like The code actions don't seem to be working with this addon? When I use: autocmd FileType cs nnoremap <buffer> Krr :OmniSharpGetCodeActions<CR> I get code actions just fine from omnisharp-vim, but then if I use the following: nmap Krr <Plug>(coc-codeaction) I don't get anything? I just get an error of
A minor one but it doesn't appear as if the usings sorting or deletion functionality exists? With omnisharp-vim there is Another minor one. With omnisharp-vim you can find the type of the variable you're under with Also finally I've had issues with omnisharp on both addons, so I had to compile it myself (which makes more sense as well as I can point them both to the same place then instead of having two versions of omnisharp). I know that someone added in the ability to use the custom path for this addon. But it's not in version you can download directly with coc? I had to compile it myself to get that, and I had a few issues doing that as the version number hadn't been changed either. I assume this isn't actually a problem and you're just waiting for other features to add for a larger release? But I thought I should bring it to your attention in case it is meant to be added. Thank you again. Could you possibly address the above points for me? I'll also try and find some time to contribute to the project. |
We can probably do this in Have a look at my vimrc: https://github.com/v-yadli/vimrc/blob/eb8fca1905262885a64ae82399cab8377be4d8e1/vsim.vim#L423
For the code action, coc-declaration, coc-implementation stuff, try get the latest version (0.27) and then download the language server again -- it's improved a few days ago.
Also, for the o# version thing... Just wait for new releases, the version is not hard coded in coc-omnisharp. It finds the latest version. |
Is there no support for semantic highlighting like omnisharp-vim has? Or is some extra configuration needed? Because I don't have any, I only have the defaultt csharp highlighting that comes with vim.
The text was updated successfully, but these errors were encountered: