Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch missing GITHUB_TOKEN sooner #60

Open
jayvdb opened this issue Jun 13, 2018 · 0 comments
Open

Catch missing GITHUB_TOKEN sooner #60

jayvdb opened this issue Jun 13, 2018 · 0 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Jun 13, 2018

The deploy error message for missing GITHUB_TOKEN is a bit confusing.

This will occur on forks when they forget to set GITHUB_TOKEN.

Also it is wasteful to do a full master build and it fail on deploy because of missing GITHUB_TOKEN.
jayvdb added a commit to jayvdb/gsoc-prep-tasks that referenced this issue Jun 13, 2018
@jayvdb
.travis.yml: Check GITHUB_TOKEN before deploy
410adc9 
Closes coala#60
@jayvdb jayvdb mentioned this issue Jun 13, 2018
Open
jayvdb added a commit to jayvdb/gsoc-prep-tasks that referenced this issue Jun 13, 2018
@jayvdb
.travis.yml: Check GITHUB_TOKEN before deploy
2a3fda4 
Provide a helpful error message early in build when
pushing to master without deploy variable GITHUB_TOKEN.

Closes coala#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayvdb