Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-api pinned to 3.1.0 tarball #52

Open
jayvdb opened this issue Jun 11, 2018 · 2 comments
Open

github-api pinned to 3.1.0 tarball #52

jayvdb opened this issue Jun 11, 2018 · 2 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Jun 11, 2018

package.json currently has

"github-api": "https://github.com/github-tools/github/archive/v3.1.0.tar.gz",

https://www.npmjs.com/package/github-api only has v3.0.0

However there are not many commits since v3.0.0.
github-tools/github@v3.0.0...master

If none of those fixes are needed for this app, the dependency could be downgraded to v3.0.0 but allow new versions as they are properly released.
@blazeu
Copy link
Member

blazeu commented Jun 11, 2018 •
edited
Loading

Removed in #33

@jayvdb
Copy link
Member Author

jayvdb commented Jun 11, 2018

Still would be nice to know whether it was necessary to use v3.1.0 or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @blazeu