Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login locally prefills with incorrect API endpoint #179

Open
li-boxuan opened this issue Nov 1, 2018 · 4 comments
Open

Login locally prefills with incorrect API endpoint #179

li-boxuan opened this issue Nov 1, 2018 · 4 comments
Assignees
@bhawesh96
Labels
bug difficulty/low

Comments

@li-boxuan
Copy link
Member

Similar to #71

The custom endpoint should be null when starting the app on the local machine.
image
@bhawesh96
Copy link
Member

I tried to reproduce the issue. It occurs whenever the local sever is NOT localhost:8080.
eg. it'll happen when we're running on 0.0.0.0:8080 or 127.0.0.1:8080

We can resolve this by adding more conditions here

@li-boxuan
Copy link
Member Author

@bhawesh96 Yeah, that's right. Do you want to take up this issue?

@bhawesh96
Copy link
Member

Yes, I'll take it up.

bhawesh96 added a commit to bhawesh96/gh-board that referenced this issue Nov 19, 2018
@bhawesh96
login-modal.jsx: Add regex for local IPs
4e1dac1 
Add regex `/^127|^0/` to check for localhost

Closes coala#179
bhawesh96 added a commit to bhawesh96/gh-board that referenced this issue Nov 19, 2018
@bhawesh96
login-modal.jsx: Add regex for local IPs
8f9aa47 
Add regex `/^127|^0/` to check for localhost

Closes coala#179
@bhawesh96 bhawesh96 mentioned this issue Nov 19, 2018
Open
@123vivekr
Copy link
Member

@li-boxuan Is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhawesh96 bhawesh96

Labels
bug difficulty/low
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bhawesh96 @li-boxuan @123vivekr