Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API limit exceeded show Json error #127

Open
jayvdb opened this issue Jul 27, 2018 · 3 comments
Open

API limit exceeded show Json error #127

jayvdb opened this issue Jul 27, 2018 · 3 comments
Assignees

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 27, 2018

Gh-board knows the limit has been reached, and can parse this json error message if necessary.
This will be the single most common error. It should be pretty/user friendly.

Ideally showing the data it does have cached, but with a readonly feel to it.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 30, 2018

Here is what it looks like if the API limit was hit before data for a kanban page was loaded.

screenshot_of_ghboard-login_mess

If the necessary data wasnt loaded, the page should say that nicely, and possibly recommend that they login.
If they are logged in, the message should show only the relevant part of the error JSON, and render it in the main part of the screen, or a separate overlay.

@123vivekr
Copy link
Member

@jayvdb Please assign this issue to me

@123vivekr
Copy link
Member

123vivekr commented Jan 10, 2019

This is the page displayed when API limit exceeds.
20190110_105807

What I understood from this issue:
Reformat this message in a user-friendly way and display it in a separate overlay similar to this:
20190110_113231

Please correct me if I am wrong.

PS: Please ignore the dark theme
Thank you

123vivekr added a commit to 123vivekr/gh-board that referenced this issue Jan 17, 2019
This shows a modal with error message on exceeding API limit.

Fixes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Jan 17, 2019
Removes error message because a modal has been implemented.

Fixes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 2, 2019
Shows a modal with error message.
Fixes coala#127
gitmate-bot pushed a commit to 123vivekr/gh-board that referenced this issue Feb 3, 2019
This shows a modal with error message on exceeding API limit.

Fixes coala#127
gitmate-bot pushed a commit to 123vivekr/gh-board that referenced this issue Feb 3, 2019
Removes error message because a modal has been implemented.

Fixes coala#127
gitmate-bot pushed a commit to 123vivekr/gh-board that referenced this issue Feb 3, 2019
Shows a modal with error message.
Fixes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 3, 2019
Shows a modal with error message.
Fixes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 3, 2019
Shows a modal with error message.
Fixes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 9, 2019
This shows a modal with error message on exceeding API limit.

Fixes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 9, 2019
This shows a modal with error message on exceeding API limit.

Fixes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 9, 2019
This shows a modal with error message on exceeding API limit.

Fixes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 10, 2019
This shows a modal with error message on exceeding API limit.

Closes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 10, 2019
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 10, 2019
This shows a modal with error message on exceeding API limit.

Closes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 10, 2019
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 12, 2019
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 12, 2019
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 12, 2019
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 12, 2019
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 12, 2019
This shows a modal with error message on exceeding API limit.

Closes coala#127
123vivekr added a commit to 123vivekr/gh-board that referenced this issue Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants