-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider minifying the angular package #56
Comments
Thanks for reporting this issue! @coala-analyzer/coala-contributors, your aid is required, fellow coalaian. Help us triage and solving this issue! |
As a "hacker", you can always deminify if you want to edit. I think you should minify it definitely, more so if the performance increase is whopping 50% |
I don't see 30kb to be much. BTW: when you calculated 20-30kb, did you compare the final pypi packages ? Or the minified js file vs the non minified one ? Because the tar.gz compression |
@AbdealiJK But yeah I think sdist will do that dirty work significantly. So I think maybe we could just leave for now. Not sure if it's wise. |
I'd say keep it low priority - after your gsoc deliverables are done |
but if you access the page a 1000 times, 50kb -> 50mb |
We could minify the js, html etc related to angular files before packaging.
Pros:
Cons
As an user, I am inclined towards Pros as the reduction in size would be more than 50%. it would be like saving 20-30 KBs. I agree it's very small size but again why not save it if we could.
As a hacker, people might wanna customise the application and use it as per their needs. Not sure about its possibility.
Thoughts?
CC @Uran198 @AbdealiJK @sils1297
The text was updated successfully, but these errors were encountered: