Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group results based on the file they belong to #36

Open
tushar-rishav opened this issue Mar 6, 2016 · 2 comments
Open

Group results based on the file they belong to #36

tushar-rishav opened this issue Mar 6, 2016 · 2 comments

Comments

@tushar-rishav
Copy link
Member

Currently, irrespective of a file the results belong, they're being shown all at once. It'd look like mess when we have results for say 20 different files or even more and each file having 10 source ranges. Imagine, user will have to scroll all the way down to go through all the files' results.
Now we can do two things to avoid this:

  1. Display only file names in result tab. Clicking on the file names would display all the results for corresponding file. Clicking on another file would close the results for previous one and open for the current file. Can be done with simple toggle.
  2. Use pagination in case when number of files are large.

IMO 2nd option seems sustainable

cc @AbdealiJK @sils1297

@AbdealiLoKo
Copy link
Contributor

Point 1 seems to be very similar to the Files tab. Except that its an alternative UI. In the files tab we'd eventually want to hide parts of the file that have no results (Like git shows diffs)

Point 2 - pagination makes sense. but as this will be running locally I wonder if it's needed. Needless, the feature looks like a good value add (which can be set to items_in_page to -1 to disable) :) We should do it.

Also - your whole issue about too many results - Possible a good search is the correct way to solve it ? We could add a "Group by" field in the advanced search (Group by file, severity, or bear ?)

@KVGarg
Copy link

KVGarg commented Feb 2, 2019

@AbdealiJK @hemangsk after adding pagination, the advanced search filter can be further added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants