Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in Results #19

Open
AbdealiLoKo opened this issue Feb 27, 2016 · 4 comments
Open

Search in Results #19

AbdealiLoKo opened this issue Feb 27, 2016 · 4 comments

Comments

@AbdealiLoKo
Copy link
Contributor

I'm not quite sure what this search module is supposed to be doing.

When I type in g - 3rd result goes away an 2 remain. But only the first result has a g in the sys.argv line ...

Where does it search ? Where should it be searching ? Do we want an advanced search ?

  • I think it'd be better to have a series of toggle buttons with all severities (INFO, NORMAL, MAJOR) to show/hide each of them.
  • It's be nice to make a multi select choice box (from chosen library maybe?) which allows us to choose which bears to show.
  • Glob based search for files ? Along with a line range search
  • And a search box for test based (for result messages OR code line that's affected itself)
@rishabhs95
Copy link
Member

both the results actually contain g, first one has sys.argv[1], while the second one has print sys.argv in its diff data.
I think that the current search in working correctly but we can modify the search by defining some custom filters with the upgraded features, like severity?

@tushar-rishav
Copy link
Member

@rishabhs95 Well noticed! 😄 Btw currently we are considering severity ( and a few more factors too) while filtering search results. Actually severity are numbers [1..3], so they can be searched only via numbers. It's bad from UX perspective though. We'll fix it soon.
Possibly, the ambiguity will be cleared once issues like #20 are solved. Feel free to let us know if you wanna send PR?:)

@rishabhs95
Copy link
Member

okay, so I will start working with bug #20 then?

@tushar-rishav
Copy link
Member

@rishabhs95 Sure! Go ahead. I've assigned you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants