README.rst: update report image and GIF link #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new GIF and report image make README more up to date. Closes coala#141 new file: coalahtml/_coalahtml/.coafile This .coafile allows coala-html to successfully run in coalahtml/_coalahtml directory. I was able to make a successful demo of coala-html with the addition of this file.
newbazz
suggested changes
Dec 10, 2017
jayvdb
requested changes
Dec 21, 2017
| @@ -0,0 +1,16 @@ | |||
| [js] | |||
There was a problem hiding this comment.
please remove this file. It is already covered by the file https://github.com/coala/coala-html/blob/master/.coafile .
I do appreciate that you needed it to generate the image, and so it was helpful for that purpose. but it isnt needed in the repository
There was a problem hiding this comment.
And likewise remove everything in the commit message after Closes #141.
|
@Lavenderjiang Please address the comments by reviewers and let us know in case you have any doubt / query :) |
|
Close due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new GIF and report image make README more up to date.
Closes #141
new file: coalahtml/_coalahtml/.coafile
This .coafile allows coala-html to successfully run in coalahtml/_coalahtml directory. I was able to make a successful demo of coala-html with the addition of this file.
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!