Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cEP-0005: aspect and aspects should always be lowercase terms #69

Open
userzimmermann opened this issue Mar 28, 2017 · 10 comments
Open

Comments

@userzimmermann
Copy link
Member

userzimmermann commented Mar 28, 2017

Just like coala itself, the terms aspect and aspects are just too fundamental to be ever written capitalized :)

Also all new API elements in coalib containing the term aspect are stricly lowercase. So always keeping it lowercase would give a much more consistent feeling and make the future of coala even brighter :)

This requires an additional rule in cEP-0005 and some changes to existing cEP-0005 text, doc strings in coalib.bearlib.aspects, #67, and https://github.com/orgs/coala/projects/2

It further affects coala/documentation#223

@sils Please! :D

@coala/aspects-developers @EverWinter23

#aspectsYEAH

@userzimmermann userzimmermann self-assigned this Mar 28, 2017
@sils
Copy link
Member

sils commented Mar 29, 2017 via email

@userzimmermann
Copy link
Member Author

Started with correcting coala/teams#11 and https://github.com/orgs/coala/projects/2 :)

@jayvdb
Copy link
Member

jayvdb commented Apr 11, 2017

It is bad enough that we have this rule for coala; but as that is not a real word, grammar rules about it are invalid anyway.

However people use the word aspects all the time, especially in programming, without any intention that it refers to this part of coala.

There are lots of other important sub-units within coala. If named according to pep 8, they would all be lower class in the source code. That isn't reason to create special grammar rules, and more inhouse-only bears.

@userzimmermann
Copy link
Member Author

@jayvdb You got the intention correctly. It's just like the lowercase coala and only intended for in-house use. Or better: only to be applied to coala's only repositories and documentation :)

@jayvdb
Copy link
Member

jayvdb commented Apr 11, 2017

So we are not allow to use the word aspects except to talk about aspects and then we must write it the way you want?

@userzimmermann
Copy link
Member Author

@jayvdb The whole thing is only about coala's new aspects framework and the spelling rules shall only apply when related to that framework. And the @coala/aspects-developers and @sils are fine with it. As you correctly pointed out in #69 (comment) , an aspect is a general term used for many things. It's not our intention to extend our little dogma ;) to any use beyond coala's aspects framework :)

@sils
Copy link
Member

sils commented Apr 11, 2017

FWIW I'm not for this I'm fine with you having your fun as long as there is no negative impact on the rest of the community. This seems to be controversial and thus @userzimmermann it might be good to just not do it: use aspects in your spelling in your docs but leave the cEP and don't make a builtin bear? @userzimmermann please wait until we have a decision on this ok?

1 similar comment
@sils
Copy link
Member

sils commented Apr 11, 2017

FWIW I'm not for this I'm fine with you having your fun as long as there is no negative impact on the rest of the community. This seems to be controversial and thus @userzimmermann it might be good to just not do it: use aspects in your spelling in your docs but leave the cEP and don't make a builtin bear? @userzimmermann please wait until we have a decision on this ok?

@userzimmermann
Copy link
Member Author

userzimmermann commented Apr 11, 2017

@sils @jayvdb It's more about motivation than fun. Or let's say motivation through fun. It's about team bonding and identity that arises from such ideas and that kind of uniqueness. It's an important reason for the small aspects team working so well and efficiently together. We should not destroy that

I also can't really see that negative impact on the community or any real controversy. But you are right! We need a definite decision of the whole core community about this. So let's keep the cEP untouched regarding this for now. And the aspects team will just keep those spelling rules inside coalib.bearlib.aspects as an unwritten law :)

We can of course delay the aspectsYEAHBear development or just put it inside of coalib.bearlib.aspects for now and use it just for linting coalib.bearlib.aspects. That would again be much simpler in an own coala-aspects project

@coala/aspects-developers

@gitmate-bot
Copy link

This issue seems stale!

@userzimmermann please reassign yourself if you're still working on this.

(Powered by GitMate.io)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants