-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect detection of non-manifold edges/faces #805
Comments
As also explained in the help of the filter I don't know what function of the Trimesh library you are using, but if you called a function that declares to detect only non-manifold edges, and detects also the ones in the boundary, that's definitely a bug in the Trimesh library. |
That aside, I'm curious how a model with any edges that have only a single incident face would be manifold. Wouldn't a single triangle be manifold by that definition? |
That's not something that I made up:
(first results on a google search)... Therefore yes, a single triangle is a manifold shape, but not watertight (here you can find a proper set of definitions of watertightness and manifoldness of a mesh). About the other edges with 4 and 6 incident faces, they are probably result of importing from STL format: STLs are not vertex-indexed and therefore, when importing these files, vertices with same coordinates should be unified. |
Thank you for those links, it seems I did confuse water-tightness and manifoldness. |
Check all platforms you experienced the issue
What type of issue is?
Describe your issue
While debugging some non-manifold STL generation over at deadsy/sdfx#18
I came across what appears to be a bug in the detection of non-manifold meshes in
MeshLab_64bit_fp v2020.07
, observed on Mac OS 10.15.6.The two files in this link: https://www.dropbox.com/sh/3lncb9dl7pm4393/AAD_HWYFxy9QDG1MRKmnxbI3a?dl=0 both have thousands of edges that are non-manifold. That is to say, I can peek into the inside of the model. Here is a quick video showing what I'm seeing in Meshlab: https://www.dropbox.com/s/nb1f86rwle1djmw/Screen%20Recording%202020-10-02%20at%209.36.23%20PM.mov?dl=0
In Meshlab I load
bottom-quad.stl
and selectFilters > Selection > Select non Manifold Edges
after which Meshlab showsSelection: v: 4 f: 6
which I take to mean that it believes only 6 faces/4 vertices are involved in non-manifold edges. I obtain similar results when choosingSelect non Manifold Vertices
.Repeating the above with
bottom-slow.stl
, Meshlab selects zero faces/vertices, but the mesh is not manifold and shows similar trouble with openings into the inside of the model.At the issue linked above I also reproduced a Python script that uses the popular Trimesh library to parse and further inspect those files. This may or may not be useful in your diagnosis of this issue.
The text was updated successfully, but these errors were encountered: