Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Inconsistencies in duffle <action> outputs #641

Open
vdice opened this issue Feb 21, 2019 · 1 comment
Open

Inconsistencies in duffle <action> outputs #641

vdice opened this issue Feb 21, 2019 · 1 comment
Labels
cosmetic Display or aesthetic issue not affecting functionality
Milestone

Comments

@vdice
Copy link
Member

vdice commented Feb 21, 2019

Comparing the outputs of each duffle <action> cli invocation (intentionally withholding required args/params), we see the following (invoking duffle install, duffle upgrade, duffle status and duffle uninstall in that order):

 $ for action in install upgrade status uninstall; do duffle $action ; echo $?; done
Error: this command requires at least one argument: NAME (name for the installation). It also requires a BUNDLE (CNAB bundle name) or file (using -f)
Valid inputs:
	$ duffle install NAME BUNDLE
	$ duffle install NAME -f path-to-bundle.json
1
Error: This command requires at least 1 argument: the name of the installation to upgrade
1
Error: required arg is NAME (installation name
1
1

Definitely good to see all exiting non-zero properly, but a few issues/requests arise:

  1. As all invocations will minimally require an installation name, would it be possible to share the same output? And/or, better aligning of the messaging around this particular missing, required argument would be good.

  2. We see duffle uninstall outputs no messaging whatsoever. This should be addressed, ideally with same aligned messaging as mentioned in 1.

@vdice vdice added the cosmetic Display or aesthetic issue not affecting functionality label Feb 21, 2019
@radu-matei
Copy link
Member

radu-matei commented Feb 21, 2019

This is going to be tricky going forward - starting in #630, we will have stateless actions - actions that do not require an installation name - meaning the argument number / types will diverge even more - feel free to chime in #629.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cosmetic Display or aesthetic issue not affecting functionality
Projects
None yet
Development

No branches or pull requests

3 participants