Separate advanced cost model from the previous basic cost model #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
approved these changes
Oct 29, 2024
| @@ -0,0 +1,109 @@ | |||
| use std::{collections::HashMap, sync::Arc}; | |||
There was a problem hiding this comment.
make it a unit test? (can be done later)
jurplel
added a commit
that referenced
this pull request
Oct 30, 2024
will go after #200 Signed-off-by: Alex Chi <[email protected]> Co-authored-by: Benjamin Owad <[email protected]>
|
An argument could be made I think to separate the ColumnRef property too, but i'll leave it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested only briefly, quick and dirty