Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Refactor Tasks to use builders. Do not replicate startup DDL. #1594

Closed
wants to merge 18 commits into from
Closed

Refactor Tasks to use builders. Do not replicate startup DDL. #1594

wants to merge 18 commits into from

Commits on May 27, 2021

  1. Task refactoring, see extended comment. 

    - Refactor TaskDDL and TaskDML to use builders.
- Track default database OID in catalog, expose via GetDefaultDatabaseOid.
- Refuse INVALID_DB_OID to force callers to do the right thing, i.e.,
  explicitly specify what database they are interacting with.
- Change TryLoadStartupDDL to fail loudly instead of silently.
- Disable replication of TryLoadStartupDDL.
    @lmwnshn
    lmwnshn committed May 27, 2021
    Configuration menu
    Copy the full SHA
    39926e4 View commit details
    Browse the repository at this point in the history

  2. More refactoring. 

    - Add TransactionPolicy arg to QueryExecUtil::BeginTransaction.
- Change a const unique_ptr<> & to a ManagedPointer.
- Allow SetReplicationPolicy(DISABLE) if DurabilityPolicy is also DISABLE.
- Nitpick at function docstrings in QueryExecUtil.
- Question: what should DurabilityPolicy be for internal table tasks?
- Found bug, see cmu-db#1595.
    @lmwnshn
    lmwnshn committed May 27, 2021
    Configuration menu
    Copy the full SHA
    b815676 View commit details
    Browse the repository at this point in the history

  3. clang-tidy ABI fix?

    @lmwnshn
    lmwnshn committed May 27, 2021
    Configuration menu
    Copy the full SHA
    80a48aa View commit details
    Browse the repository at this point in the history

  4. FORMAT.

    @lmwnshn
    lmwnshn committed May 27, 2021
    Configuration menu
    Copy the full SHA
    cdd8d05 View commit details
    Browse the repository at this point in the history

  5. Mystery use-after-move.

    @lmwnshn
    lmwnshn committed May 27, 2021
    Configuration menu
    Copy the full SHA
    45ba9c4 View commit details
    Browse the repository at this point in the history

  6. Didn't notice it was in a loop. Also, just use the string directly.

    @lmwnshn
    lmwnshn committed May 27, 2021
    Configuration menu
    Copy the full SHA
    99f2b7f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. This is a really weird clang-tidy error.

    @lmwnshn
    lmwnshn committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    26449c9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:cmu-db/noisepage into bonk_tasks

    @lmwnshn
    lmwnshn committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    55de9f2 View commit details
    Browse the repository at this point in the history

  3. clang tidy??

    @lmwnshn
    lmwnshn committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    9ee2376 View commit details
    Browse the repository at this point in the history

  4. Fix include dependencies, thanks Matt!

    @lmwnshn
    lmwnshn committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    ff3010a View commit details
    Browse the repository at this point in the history

  5. Fix forward declares.

    @lmwnshn
    lmwnshn committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    e87eb21 View commit details
    Browse the repository at this point in the history

  6. Fix forward declares and includes.

    @lmwnshn
    lmwnshn committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    a20b4bb View commit details
    Browse the repository at this point in the history

  7. Change log info to log debug for startup ddl.

    @lmwnshn
    lmwnshn committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    906b47d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of github.com:cmu-db/noisepage into bonk_tasks

    @lmwnshn
    lmwnshn committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    02def3f View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Add Lin's comment re copying.

    @lmwnshn
    lmwnshn committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    2038aec View commit details
    Browse the repository at this point in the history

  2. Add lines between function defs.

    @lmwnshn
    lmwnshn committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    8f70457 View commit details
    Browse the repository at this point in the history

  3. Undo accidental commit.

    @lmwnshn
    lmwnshn committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    9599705 View commit details
    Browse the repository at this point in the history

  4. Add txn_policy as WriteToDB parameter. 

    Push txn_policy into the metrics manager.
    @lmwnshn
    lmwnshn committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    1233a2f View commit details
    Browse the repository at this point in the history