Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

typo in projected_columns.h document #1639

Open
wangqiim opened this issue Sep 16, 2021 · 0 comments
Open

typo in projected_columns.h document #1639

wangqiim opened this issue Sep 16, 2021 · 0 comments

Comments

@wangqiim
Copy link

Typo

document typo

/**
* ProjectedColumns represents partial images of a collection of tuples, where columns from different
* tuples are laid out continuously. This can be considered a collection of ProjectedRows, but optimized
* for continuous column access like PAX. However, a ProjectedRow is almost always externally coupled to a known
* tuple slot, so it is more compact in layout than MaterializedColumns, which has to also store the
* TupleSlot information for each tuple. The inner class RowView provides access to the underlying logical
* projected rows with the same interface as a real ProjectedRow.
* -------------------------------------------------------------------------------------
* | size | max_tuples | num_tuples | num_cols | attr_end[4] | col_id1 | col_id2 | ... |
* -------------------------------------------------------------------------------------
* | val1_offset | val2_offset | ... | TupleSlot_1 | TupleSlot_2 | ... |
* -------------------------------------------------------------------------------------
* | null-bitmap, col_id1 | val1, col_id1 | val2, col_id1 | ... |
* -------------------------------------------------------------------------------------
* | null-bitmap, col_id1 | val1, col_id2 | val2, col_id2 | ... |
* -------------------------------------------------------------------------------------
* | ... |
* -------------------------------------------------------------------------------------
*/
// PACKED for the same reason as ProjectedRow
class PACKED ProjectedColumns {

In line:25, I think it expected is

* | null-bitmap, col_id2 | val1, col_id2 | val2, col_id2 |             ...            | 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant