Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a potential bug that could cause a segment fault when insert a large tuple. #716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed a potential bug that could cause a segment fault when insert a large tuple. #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/storage/page/table_page.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ auto TablePage::GetNextTupleOffset(const TupleMeta &meta, const Tuple &tuple) co
}
auto tuple_offset = slot_end_offset - tuple.GetLength();
auto offset_size = TABLE_PAGE_HEADER_SIZE + TUPLE_INFO_SIZE * (num_tuples_ + 1);
if (tuple_offset < offset_size) {
if (tuple_offset < offset_size || tuple_offset >= BUSTUB_PAGE_SIZE) {
return std::nullopt;
}
return tuple_offset;
Expand Down
Loading