Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments on the translation #99

Open
Mohamed-Waiel-Shikfa opened this issue Jan 18, 2025 · 1 comment
Open

Comments on the translation #99

Mohamed-Waiel-Shikfa opened this issue Jan 18, 2025 · 1 comment

Comments

@Mohamed-Waiel-Shikfa
Copy link
Contributor

I had a couple of thoughts on the translation feature:

  1. If the translation is handled by a library, could we easily add support for other languages? We could have qualified reviewers for each language. For example, I could help review a French translation. This would make the library more accessible to speakers of various languages.

  2. It might be a good idea to put the translation dictionary in a separate file, maybe a translation.json. This could help with organization and make it easier to manage updates.

Just some suggestions that I could work on if they are well received.
@schmave
Copy link
Member

schmave commented Jan 21, 2025

I agree that this would be nice, but it's not a priority for us at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schmave @Mohamed-Waiel-Shikfa