Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for subscribers to be deleted #22

Open
oubiwann opened this issue Dec 8, 2017 · 0 comments
Open

Allow for subscribers to be deleted #22

oubiwann opened this issue Dec 8, 2017 · 0 comments

Comments

@oubiwann
Copy link
Member

oubiwann commented Dec 8, 2017

The core functionality for this is provided by the core.async/unsub function:

(unsub p topic ch)

However, this requires that we hold onto the channel that gets subscribed to a publisher. The pubsub messaging impl needs to be updated to track subscribers. These should probably be named, too -- which means a handful of functions need to be updated. We should also provide API fns for getting all subscribers, one subscriber, unsubscribing all subscribers, and unsubscribing one.

This will mean we can update the shutdown for the default-subscriber component to unsub its own and then update the messaging component to unsubscribe all. The timer component can unsubscribe its own, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant