Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No additional data sent #6

Open
Luoti opened this issue Jan 18, 2012 · 4 comments
Open

No additional data sent #6

Luoti opened this issue Jan 18, 2012 · 4 comments

Comments

@Luoti
Copy link

Luoti commented Jan 18, 2012

Hi!

I used this plugin with jquery 1.6.1, but when I upgraded to 1.7.1 the additional form data was not sent. With blind troubleshooting I found out that the additional data was not found in options.data, but it was in the origOptions.data. I fixed it by just adding:

options.data = origOptions.data;

to line 137.

@tallgreentree
Copy link

+1 - this fix works for me as well. Perhaps a check for nil on both options.data and origOptions.data is needed?

@ghost
Copy link

ghost commented Jun 18, 2012

+1 Great fix, I was looking for it. Should be added to the actual plugin!

@tony2nite
Copy link

+1 Yep, can't add additional options without this

cmlenz added a commit that referenced this issue Jul 6, 2013
@cmlenz
Copy link
Owner

cmlenz commented Jul 6, 2013

Finally applied :P. Thanks!

@cmlenz cmlenz closed this as completed Jul 6, 2013
@swiftyone
Copy link

Because of this fix there seems to be a problem with data that is added to the options in a beforeSend callback.
I think the line should be something like:

options.data = $.extend({}, origOptions.data, options.data);

There are still issues, as this does not reflect removing stuff from options.data in the beforeSend callback, but at least it does not ignore additional data which seems to be the more common use case.

@cmlenz cmlenz reopened this Jul 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants