Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.modulesReady should resolve when all modules are ready (not just dynamic imports) #5

Open
cmalven opened this issue May 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@cmalven
Copy link
Owner

cmalven commented May 25, 2021

Currently, app.modulesReady is a promise that resolves when all dynamically imported modules are ready to work with. However, with some setups this could mean that while all dynamically imported modules are ready, initialModules might not be.

The ideally way to solve this would be to add promises even for initially imported modules, and have app.modulesReady resolve when all initially imported and dynamically imported modules are ready.

@cmalven cmalven added the bug Something isn't working label May 25, 2021
@cmalven
Copy link
Owner Author

cmalven commented May 25, 2021

Relevant code is around https://github.com/cmalven/modu/blob/main/index.js#L274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant