-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libpg 12+ working branch #98
Draft
clux
wants to merge
4
commits into
main
Choose a base branch
from
libpq
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lol this does totally work when adding in |
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Note to self; tried the other potential fix branch on pq-sys with the following diff: diff --git Dockerfile Dockerfile
index de1c119..78b7253 100644
--- Dockerfile
+++ Dockerfile
@@ -137,6 +137,12 @@ ENV PATH=$PREFIX/bin:$PATH \
PKG_CONFIG_PATH_X86_64_UNKNOWN_LINUX_MUSL=$PREFIX/lib/pkgconfig \
PG_CONFIG_X86_64_UNKNOWN_LINUX_GNU=/usr/bin/pg_config \
PG_CONFIG_X86_64_UNKNOWN_LINUX_MUSL=/musl/bin/pg_config \
+ PQ_LIB_DIR_x86_64_UNKNOWN_LINUX_MUSL=$PREFIX/lib \
+ PQ_LIB_DIR_x86_64=$PREFIX/lib \
+ PQ_LIB_DIR=$PREFIX/lib \
+ PQ_LIB_STATIC=true \
+ PQ_LIB_STATIC_x86_64_UNKNOWN_LINUX_MUSL=$PREFIX/lib \
+ PQ_LIB_STATIC_x86_64=$PREFIX/lib \
OPENSSL_STATIC=true \
OPENSSL_DIR=$PREFIX \
SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt \
diff --git test/pqcrate/Cargo.toml test/pqcrate/Cargo.toml
index a158fac..02ff851 100644
--- test/pqcrate/Cargo.toml
+++ test/pqcrate/Cargo.toml
@@ -5,5 +5,5 @@ version = "0.1.0"
[dependencies]
#pq-sys = "0.4.5"
-pq-sys = { git = "https://github.com/golddranks/pq-sys.git", rev = "8bc178b2a3859704585f4d4b39d2942c040e350b" }
+pq-sys = { git = "https://github.com/spruce/pq-sys.git", rev = "c55ab302875b5639779d2e0caa9f1ae71ac2464b" }
openssl = "*" does not work. needs the explicit static link dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to link
libpgport
andlibpgcommon
since libpg12manually compiling in two extra pg libraries in the stable image on this branch:
libpgcommon
is found in src/commonlibpgport
is found in src/portand also using the link flags from an ancient pr: https://github.com/sgrif/pq-sys/pull/28/files for sgrif/pq-sys#27 but that's been ignored for 2 years...